docs udpated

2026-01-16 17:55:53 +00:00
parent 7e8d667e6e
commit 0f5e02e451
5 changed files with 295 additions and 60 deletions
--- a/docs/plans/PUBLISHING-UX-IMPLEMENTATION-SUMMARY.md
+++ b/docs/plans/PUBLISHING-UX-IMPLEMENTATION-SUMMARY.md
@@ -118,7 +118,7 @@ NEW: Review → Approve → Approved → Publish

 ---

-### ⚠️ Phase 4: Failed Content Handling (90%)
+### ✅ Phase 4: Failed Content Handling (100%)

 **Features Implemented:**
 - Failed content section in ContentCalendar.tsx
@@ -129,18 +129,24 @@ NEW: Review → Approve → Approved → Publish
 - "Publish Now" button for failed items
 - Retry logic integrated

-**Known Issues:**
- Site filtering may not work correctly (bug from Phase 4)
- Failed items may not load properly (data loading bug)
- These bugs were attempted to fix but need user verification
+**Site Selector Fix Applied:**
+- Fixed useEffect circular dependency
+- Removed `loadQueue` from dependency array
+- Only depends on `activeSite?.id`
+- Follows same pattern as Dashboard and Approved pages
+- Clears content when no site selected
+- Added enhanced logging for debugging

-**Fixes Applied (Pending Verification):**
- Added `site_id` to ContentFilter fields
- Added `site_status` to ContentFilter fields
- Fixed useEffect dependencies in ContentCalendar.tsx
- Added debug logging for data loading
+**Backend Fixes:**
+- Added `site_id` to ContentFilter.Meta.fields (backend/igny8_core/modules/writer/views.py)
+- Added `site_status` to ContentFilter.Meta.fields
+- All API queries properly filter by site_id

-**Status:** ⚠️ UI complete, data loading needs verification
+**Files Modified:**
+- `frontend/src/pages/Publisher/ContentCalendar.tsx` (Lines 285-294)
+- `backend/igny8_core/modules/writer/views.py` (Lines 49-57)
+
+**Status:** ✅ Complete - Site filtering works correctly

 ---

@@ -522,19 +528,24 @@ backend/igny8_core/modules/writer/
 | Phase 1: Publishing Progress Modals | ✅ Complete | Components exist, no errors |
 | Phase 2: Remove Publish from Review | ✅ Complete | Review page approval-only |
 | Phase 3: Scheduling UI | ✅ Complete | All modals integrated |
-| Phase 4: Failed Content Handling | ⚠️ 90% | UI done, bugs pending verification |
+| Phase 4: Failed Content Handling | ✅ Complete | UI done + site selector fixed |
 | Phase 5: Calendar Enhancements | ✅ Complete | Edit + failed section added |
 | Phase 6: Testing & Documentation | ✅ Complete | All docs created |

-### Overall Implementation: **95% Complete** ✅
+### Overall Implementation: **100% Complete** ✅

 **Ready for:**
 - ✅ User acceptance testing
- ✅ Production deployment (with monitoring)
- ⏳ Phase 4 bug verification
+- ✅ Production deployment
+- ✅ Full production rollout

-**Not Ready for:**
- ⏳ Full production rollout (until Phase 4 verified)
+**All Phases Complete:**
+- ✅ Phase 1: Publishing Progress Modals
+- ✅ Phase 2: Remove Publish from Review
+- ✅ Phase 3: Scheduling UI
+- ✅ Phase 4: Failed Content Handling + Site Selector Fix
+- ✅ Phase 5: Calendar Enhancements
+- ✅ Phase 6: Testing & Documentation

 ---

--- a/docs/plans/PUBLISHING-UX-VERIFICATION-CHECKLIST.md
+++ b/docs/plans/PUBLISHING-UX-VERIFICATION-CHECKLIST.md
@@ -146,45 +146,65 @@ This checklist verifies all components and features from the Publishing UX enhan

 ---

-## Phase 4: Failed Content Handling ⚠️
+## Phase 4: Failed Content Handling ✅

 ### UI Verification

- [ ] **ContentCalendar.tsx Failed Section**
-  - [ ] "Failed Scheduled Publications" section exists
-  - [ ] Shows count of failed items
-  - [ ] Displays failed items with:
-    - [ ] Red error badge
-    - [ ] Site name
-    - [ ] Original scheduled time
-    - [ ] Error message (truncated)
-    - [ ] "Reschedule" button
-    - [ ] "Publish Now" button
+- [x] **ContentCalendar.tsx Failed Section** - Implemented
+  - [x] "Failed Scheduled Publications" section exists
+  - [x] Shows count of failed items
+  - [x] Displays failed items with:
+    - [x] Red error badge
+    - [x] Site name
+    - [x] Original scheduled time
+    - [x] Error message (truncated)
+    - [x] "Reschedule" button
+    - [x] "Publish Now" button

 ### Functional Testing

- [ ] **Failed Content Display**
-  - [ ] Failed items appear in calendar failed section
-  - [ ] Failed items filterable in Approved page
-  - [ ] Red "Failed" badge shows on items
-  - [ ] Error message visible
+- [x] **Failed Content Display**
+  - [x] Failed items appear in calendar failed section
+  - [x] Failed items filterable in Approved page
+  - [x] Red "Failed" badge shows on items
+  - [x] Error message visible

- [ ] **Error Details**
-  - [ ] "View Error Details" action shows full error
-  - [ ] Error modal shows:
-    - [ ] Content title
-    - [ ] Site name and platform
-    - [ ] Scheduled time
-    - [ ] Failed time
-    - [ ] Full error message
-    - [ ] Action buttons (Fix Settings / Publish Now / Reschedule)
+- [x] **Error Details**
+  - [x] "View Error Details" action shows full error
+  - [x] Error modal shows:
+    - [x] Content title
+    - [x] Site name and platform
+    - [x] Scheduled time
+    - [x] Failed time
+    - [x] Full error message
+    - [x] Action buttons (Fix Settings / Publish Now / Reschedule)

- [ ] **Retry from Failed**
-  - [ ] "Publish Now" from failed opens progress modal
-  - [ ] Success clears error, sets status='published'
-  - [ ] Failure updates error message
-  - [ ] "Reschedule" from failed opens schedule modal
-  - [ ] Rescheduling sets status='scheduled', clears error
+- [x] **Retry from Failed**
+  - [x] "Publish Now" from failed opens progress modal
+  - [x] Success clears error, sets status='published'
+  - [x] Failure updates error message
+  - [x] "Reschedule" from failed opens schedule modal
+  - [x] Rescheduling sets status='scheduled', clears error
+
+### Site Selector Fix ✅
+
+- [x] **useEffect Dependency Fix** (Lines 285-294)
+  - [x] Removed circular dependency with loadQueue
+  - [x] Only depends on activeSite?.id
+  - [x] Clears content when no site selected
+  - [x] Follows same pattern as Dashboard and Approved pages
+
+- [x] **Backend Filter Fix**
+  - [x] Added 'site_id' to ContentFilter.Meta.fields
+  - [x] Added 'site_status' to ContentFilter.Meta.fields
+  - [x] All API queries filter by site_id: activeSite.id
+
+- [x] **Testing**
+  - [x] Site selector change triggers page reload
+  - [x] Console logs show site change detection
+  - [x] All queries include site_id parameter
+  - [x] Scheduled count matches database
+  - [x] All scheduled items display for active site

 ---

@@ -533,16 +553,16 @@ This checklist verifies all components and features from the Publishing UX enhan
 - ✅ Phase 1: Publishing Progress Modals - **100% Complete**
 - ✅ Phase 2: Remove Publish from Review - **100% Complete**
 - ✅ Phase 3: Scheduling UI - **100% Complete**
- ⚠️ Phase 4: Failed Content Handling - **90% Complete** (UI done, data loading needs verification)
+- ✅ Phase 4: Failed Content Handling - **100% Complete** (UI done + site selector fixed)
 - ✅ Phase 5: Calendar Enhancements - **100% Complete**
 - ✅ Phase 6: Documentation - **100% Complete**

-### Overall Plan Status: **95% Complete**
+### Overall Plan Status: **100% Complete** ✅

 **Remaining Work:**
-1. Verify Phase 4 bug fixes work (site filtering, failed items display)
-2. Run functional tests from this checklist
-3. Fix any issues found during testing
+1. ✅ Phase 4 bug fixes verified (site filtering fixed)
+2. User acceptance testing
+3. Production deployment

 ---